Optional ignoring of RegBase autosave

[WAJIM]

After calling RegMan.AddReg/DelReg/ChangeReg funtions HUB automatically call RegMan.Save function to save base on HDD.

When I calling RegMan.DelReg on my HUB with RegBase ~5000 users, removal of Regs works very slowly (~5 Regs/second) because of write of base on a HDD after every DelReg.

I suggest to make optional ignoring of autosave RegBase after RegMan.AddReg/DelReg/ChangeReg funtions.

Example: RegMan.DelReg(sNick, bNoSave) or RegMan.DelRegFast(sNick)

[Mutor]

And if the hub should fail by script or system issues before a save is made all such
changes would be lost. Barring a cleaner, why on earth would you be mass deleting users?

[Enuri]

Agree with WAJIM. Recently i removed about ~8000 regs, i had use timer to clear reg base on working hub.

Also, i don't want to create a new topic, so how about make a ProfMan.Save() function? Now only shutdown or restart saves profiles.

[Mutor]

Why would you delete 8000 registered accounts?
I see no practical or reasonable cause for this.

[Enuri]

Why would you delete 8000 registered accounts?
I see no practical or reasonable cause for this.

Just to delete regs that are not used for a long time... Less regs gives a best performance, i think

[WAJIM]

Why would you delete 8000 registered accounts?

No, every month invokes purging function, that removes unused accounts, ~100-300.  

And if the hub should fail by script or system issues before a save is made

These are my problems. 

[Mutor]

Well I agree with that, but to dump 8k users at once is foolish.
A proper cleaner ensures users absent for x amount of days
are deleted. In this way only a few users are deleted on any
one cycle. I might be wrong as I have not seen the script
but it would seem your problems and WAJIM's may well be
due to poor scripting methods.

[Enuri]

dump 8k users at once is foolish.

Yes. But it's first time when i clear my reg base  

So, if some linux user needs this function now:

0) Create a backup 
1) open src/LuaRegManLib.cpp
2) Find function started with static int DelReg(lua_State * L)
3) Copy this function with new name like static int DelRegFast(lua_State * L)
4) Delete hashRegManager->Save(); in the end of the function
5) Find static const luaL_reg regman_funcs[] =  {
6) Add { "DelRegFast", DelRegFast }, to this array
7) Compile and enjoy

[Mutor]

No, every month invokes purging function, that removes unused accounts, ~100-200. 

Well Sir, there is your problem, you don't run a cleaner once a month.
Increase you frequency to at least once a day. Then there will be no
lag or stall in the hub. My own cleaner runs once every hour.

The hub shouldn't be recoded to suit poor methods, your script should
be recoded to run properly with respect to the API.

[WAJIM]

but it would seem your problems and WAJIM's may well be due to poor scripting methods.

No, I well see, how the size of RegisteredUsers.xml changes in a range from 0 up to 800K many times when I make many RegMan.DelReg calls.

[Mutor]

Yes. But it's first time when i clear my reg base  

So, if some linux user needs this function now:...

So you mod the c++ and recompile over the one time pain from
cleaning an ill maintained registered users database? Add to that the risk
of losing changes made on crash. Is everyone in Russia crazy?  

[Mutor]

No, I well see, how the size of RegisteredUsers.xml changes in a range from 0 up to 800K many times when I make many RegMan.DelReg calls.

Well that's the point, properly coded, you would never BE making many DelReg calls.
The xml file will be the size it needs to be when you're done fucking with it.
Is it any wonder the file size changes when it's being re-written?

[Enuri]

Add to that the risk of losing changes made on crash

Following this logic, why settings and bans aren't saved automatically after calling SetMan.Set... ?

. Is everyone in Russia crazy?  

Oh, yes 

[WAJIM]

Well that's the point, properly coded, you would never BE making many DelReg calls.

No, simply the hub should process function correctly, instead of through an ass. 

The xml file will be the size it needs to be when you're done fucking with it.
Is it any wonder the file size changes when it's being re-written?

Therefore I have created this topic. For improvement of work with database.

For what purposes there is a function RegMan.Save() ?! 

[Mutor]

No, simply the hub should process function correctly, instead of through an ass.  
Therefore I have created this topic. For improvement of work with database.

I respectfully submit your scripting methods are what need improvement.

For what purposes there is a function RegMan.Save() ?!  

I have asked the very same question. Although I'm not certain it's the same for
the Win32 hub. Moreover source for the Win32 is not available.

After thinking it over, I agree the save function should not be called automatically
for any of the 'Manager' calls. I can only assume PPK was guarding again sloppy script.
So I see both of these as correctable problems.

[WAJIM]

So, if some linux user needs this function now:

Thanks, but I'm win32 user. 

[PPK]

Is everyone in Russia crazy?  

YES!


Problem fixed, removed auto save. From PtokaX 0.4.1.2 it will be scripter responsibility to save regs when it is needed

[Mutor]

Thank you. I've always wanted enough rope to hang myself.

[WAJIM]

Problem fixed, removed auto save.

Thanks, PPK!